Handle negative zero in number multiplication #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is related to #1855. When I checked it with jerry-test-suite and jerry-tests, there was no regression. And when I run benchmarks 10kk, and 1kk, it also shows no regression on x86_64. Could you check the correctness and run sunspider? |
|
The bug must be elsewhere. -0 is not an integer number in JerryScript. I suspect the division is the problem. Let me check. |
zherczeg
reviewed
May 26, 2017
jerry-core/vm/vm.c
Outdated
| @@ -1764,7 +1764,7 @@ vm_loop (vm_frame_ctx_t *frame_ctx_p) /**< frame context */ | |||
| && -(ECMA_INTEGER_MULTIPLY_MAX * ECMA_INTEGER_MULTIPLY_MAX) >= ECMA_INTEGER_NUMBER_MIN, | |||
| square_of_integer_multiply_max_must_fit_into_integer_value_range); | |||
|
|
|||
| if (ecma_are_values_integer_numbers (left_value, right_value)) | |||
| if (left_value != 0 && right_value != 0 && ecma_are_values_integer_numbers (left_value, right_value)) | |||
| { | |||
There was a problem hiding this comment.
Ok, it is a bug with the multiplication but we need to move this check down to the if starting with:
if (-ECMA_INTEGER_MULTIPLY_MAX <= left_integer
Add:
&& left_integer != 0
&& right_integer != 0
|
Ok. I'll move it. Thank you for review. |
Keep sign for zero. For example, 1 / (0 * (-1)) should be -Infinity, not +Infinity. JerryScript-DCO-1.0-Signed-off-by: Sanggyu Lee [email protected]
LaszloLango
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep sign for zero.
For example, 1 / (0 * (-1)) should be -Infinity, not +Infinity.
JerryScript-DCO-1.0-Signed-off-by: Sanggyu Lee [email protected]